Closed
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
priettt
force-pushed
the
priettt/archsToSharedObjectsMap
branch
from
83109d9 to
97a521a
Compare
Comment on lines
+21
to
+22
| * 1. Compresses each shared object file using Zstd compression | ||
| * 2. Stores the compressed files in compressedSharedObjectFilesDirectory, preserving the architecture directory structure |
Member
There was a problem hiding this comment.
I didn't realise we were doing Zstd compression on SO files. IMO it'd be worth breaking that into a separate task that takes the uncompressed SO files as an input and the compressed files as an output. Sorry for the confusion from our discussion yesterday
|
|
||
| // Serialize the map to JSON and write it to the output file | ||
| val serializableMap = ArchitecturesToHashedSharedObjectFilesMap(outputMap) | ||
| architecturesToHashedSharedObjectFilesMap.get().asFile.outputStream().use { outputStream -> |
Member
There was a problem hiding this comment.
Suggested change
| architecturesToHashedSharedObjectFilesMap.get().asFile.outputStream().use { outputStream -> | |
| architecturesToHashedSharedObjectFilesMap.get().asFile.outputStream().use { outputStream -> |
It'd be worth using a buffered stream here to improve perf
| } | ||
|
|
||
| private fun getUnitySharedObjectFiles(project: Project, data: AndroidCompactedVariantData): File { | ||
| // TODO: Verify if errors should be thrown if the directories or SO files are not found. Improve error messaging. |
Member
There was a problem hiding this comment.
Are these todo comments new or were they present in the previous code that's been adapted into this source file?
Contributor
Author
There was a problem hiding this comment.
these are new, I'm adding them so I can then think about any uncommon codepaths
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
==========================================
+ Coverage 85.25% 85.40% +0.14%
==========================================
Files 464 466 +2
Lines 10518 10523 +5
Branches 1556 1558 +2
==========================================
+ Hits 8967 8987 +20
+ Misses 875 858 -17
- Partials 676 678 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This is one of the 4 tasks NdkUploadTask will get separated into.
This task receives a directory with architectures as its input, and outputs a map of each architecture to a list with every shared object file path of that architecture.
For instance, if the input directory is this:
The result will be this map:
I also moved the logic to find the architecture directories to the task registration, so it's passed as a provider to the task.
Testing
Added an integration test for the task, still need to test the registration.